Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backend): Add orderBy to GetOrganizationListParams #3164

Merged
merged 3 commits into from
Apr 15, 2024
Merged

feat(backend): Add orderBy to GetOrganizationListParams #3164

merged 3 commits into from
Apr 15, 2024

Conversation

IGassmann
Copy link
Contributor

@IGassmann IGassmann commented Apr 10, 2024

Description

This adds the orderBy parameter to GetOrganizationListParams.

The getOrganizationList method in the OrganizationApi was missing the orderBy parameter, as @mario-jerkovic correctly pointed out in https://github.com/orgs/clerk/discussions/3152.

The related documentation PR: clerk/clerk-docs#891

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented Apr 10, 2024

🦋 Changeset detected

Latest commit: 19bbbc3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@clerk/backend Minor
@clerk/express Patch
@clerk/fastify Patch
gatsby-plugin-clerk Patch
@clerk/nextjs Patch
@clerk/remix Patch
@clerk/clerk-sdk-node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@IGassmann IGassmann changed the title feat(clerk-js): Add orderBy to GetOrganizationListParams feat(backend): Add orderBy to GetOrganizationListParams Apr 10, 2024
@IGassmann IGassmann marked this pull request as ready for review April 10, 2024 15:42
Copy link
Contributor

@dimkl dimkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚀 Thank for the contribution.
I will open an internal ticket so we can also add/update the orderBy parameter in the following endpoints but feel free to open a PR for those 2 and i will review it:

PS: this change will be added to the latest beta version. In order to backport this to the current latest version you need to open a PR with release/v4 as base branch but since we will release the beta version as stable soon, i would consider using the latest beta instead. For beta docs visit: https://beta.clerk.com/docs

@IGassmann
Copy link
Contributor Author

@dimkl it looks like you have to approve the running of the GitHub workflows, before I'm able to merge.

Copy link
Member

@nikosdouvlis nikosdouvlis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻

@nikosdouvlis nikosdouvlis merged commit 142ded7 into clerk:main Apr 15, 2024
4 checks passed
@dimkl
Copy link
Contributor

dimkl commented Apr 15, 2024

@IGassmann even if i approve it, the actions won't run. Nikos will merge it :)

@nikosdouvlis
Copy link
Member

@dimkl it looks like you have to approve the running of the GitHub workflows, before I'm able to merge.

We have a few GH variables that cannot be shared with forked repos - we will most liekly push the fix this week, so I will manually merge and run CICD for now :)

Thank you for your contribution!

@IGassmann IGassmann deleted the igor/getorganizationlist-orderby branch April 15, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants